Repository navigation
Remove array_session - #10681
Merged
Merged
Remove array_session#10681
Conversation
robert3005
force-pushed
the
rk/split-array-12-remove-array-session
branch
from
October 21, 2026 21:42
236f7d2 to
3aa4e4d
Compare
Merging this PR will regress 10 benchmarks4 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
robert3005
force-pushed
the
rk/split-array-12-remove-array-session
branch
2 times, most recently
from
October 22, 2026 00:04
54dfbd0 to
ba0ba3e
Compare
joseph-isaacs
added
the
action/bench-sql
github-actions
Bot
removed
the
action/bench-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals Profiling 📖Commits: PR datafusion / vortex-file-compressed / ns (1.002x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb NVMe 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.999x ➖, 1↑ 1↓)
datafusion / parquet / ns (1.004x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.991x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.996x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.999x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.996x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.004x ➖, 0↑ 1↓)
duckdb / parquet / ns (0.996x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=10 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.993x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.999x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.996x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.004x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.000x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.002x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.002x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.003x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: Clickbench on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.998x ➖, 0↑ 0↓)
datafusion / parquet / ns (0.996x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.001x ➖, 0↑ 0↓)
duckdb / parquet / ns (1.000x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.214x ➖, 0↑ 6↓)
datafusion / parquet / ns (1.092x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.019x ➖, 1↑ 0↓)
duckdb / parquet / ns (1.093x ➖, 0↑ 2↓)
|
robert3005
force-pushed
the
rk/split-array-12-remove-array-session
branch
from
October 23, 2026 11:19
ba0ba3e to
523fe18
Compare
`vortex_array::array_session()` was a shared constructor that every test, bench and doc example called, whatever it needed from the session. Callers now build the session they need: `VortexSession::empty()` creates vortex-array's session variables on first use, and callers register anything else themselves. Tests share their module's session through a `static SESSION: LazyLock<_>` built with the setup those tests need. Tests that change their session after setting it up, need a different setup, or create a `RuntimeSession` (which holds the runtime current at creation) keep a local session. Benches build their session the same way, in a `static SESSION` that registers vortex-array's session variables explicitly, and force it in `main` before the harness starts, so no benchmark iteration pays for session setup. Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ps4mp7KF5c4p66aoSoXx5j
…roundtrip The test was added with the three-argument signature after try_new gained an ExecutionCtx parameter, so vortex-file's tests do not compile on develop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ps4mp7KF5c4p66aoSoXx5j Signed-off-by: Claude <noreply@anthropic.com>
robert3005
force-pushed
the
rk/split-array-12-remove-array-session
branch
from
October 23, 2026 14:45
523fe18 to
1860149
Compare
mhk197
reviewed
Oct 23, 2026
|
|
||
| static SESSION: LazyLock<VortexSession> = LazyLock::new(|| { | ||
| let session = vortex_array::array_session(); | ||
| let session = VortexSession::empty() |
Contributor
There was a problem hiding this comment.
instead of explicitly writing the for every benchmark in fastlanes... can we just have a helper?
Contributor
There was a problem hiding this comment.
or just do vortex_array::initialize(session)?
Contributor
Author
There was a problem hiding this comment.
the whole point is that after the split vortex_array::initialize is not enough and I would like to have targeted instantiations for given tests
mhk197
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vortex_array::array_session()was a shared constructor that every test, bench and doc example called, whatever it needed from the session. Callers now build the session they need:VortexSession::empty()creates vortex-array's session variables on first use, and callers register anything else themselves.Tests share their module's session through a
static SESSION: LazyLock<_>built with the setup those tests need. Tests that change their session after setting it up, need a different setup, or create aRuntimeSession(which holds the runtime current at creation) keep a local session.