Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NaN, positive infinity, and negative infinity for public search score thresholds[0, 1]rangeWhy
Invalid search parameters can silently turn retrieval into a wrong empty result. This failure mode was reported in Microsoft Agent Framework #9317 and fixed for its Cosmos-specific parameter ranges in #9318.
OpenViking has a separate reachable gap: its public score-threshold fields accept non-finite floats. With the current comparison logic,
NaNand positive infinity reject every finite score, while negative infinity accepts every finite score. JSON overflow such as1e999also becomes infinity before validation.OpenViking retrieval scores are not universally bounded because their scale depends on the backend, metric, and reranking path. The shared validation therefore rejects only non-finite values and keeps finite values outside
[0, 1]valid.Validation
34 passed168 passed; one unrelated skill reindex test failed with the same frontmatter error on the untouched base commit19/19assertions passed