Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Fix - can't toggle gateway high availability#694

Open
azzamsa wants to merge 1 commit into
vmware-archive:masterfrom
azzamsa:ha
Open

Fix - can't toggle gateway high availability#694
azzamsa wants to merge 1 commit into
vmware-archive:masterfrom
azzamsa:ha

Conversation

@azzamsa

@azzamsa azzamsa commented Jul 24, 2020

Copy link
Copy Markdown
Contributor
        if ha: # <----
            gateway.Configuration.HaEnabled = E.HaEnabled(ha)

if ha value is set to False the code will never be executed. So that the Gateway High Availability will never be Disabled.

        if ha is not None: # <----
            gateway.Configuration.HaEnabled = E.HaEnabled(ha)

This change is Reviewable

@mukultaneja mukultaneja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@azzamsa

azzamsa commented Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

Any update about this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants