Repository navigation
docs: small fixes — CLAUDE.md --tag, ADR index backfill, H4 §4 re-ratified (v3 supersedes P12) - #354
Merged
Merged
Conversation
…H4 §4 re-ratified (v3 supersedes P12) - CLAUDE.md documented `vfkb add … --tags a,b`, but the CLI flag is `--tag` (it errors with "unknown flag --tags"; observed while writing the ADR-0077 test). - docs/adr/README.md was missing ADR-0067 to ADR-0076. Rows are generated from each ADR's own title, so the index is now complete through ADR-0077. - H4-DEVELOPMENT-ROADMAP.md §4 is re-ratified (operator ruling 2026-10-19, brain ef3500b68252). The v3 cycle is the ▶ Current action in Ruling 4's order, with per-theme state; P12 is ⏸ paused, not abandoned, and its section is kept intact. The order chain gains a v3 line. The note on P12's two owed rulings now says ADR-0076 ruled them. - task-priority.md: the "roadmap is stale" banner is replaced by a note on the re-ratification.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…n logged in the roadmap header, R3 state The review of #354 found nothing blocking. Applied: - The ADR index marks amended ADRs the way it already did for ADR-0050: 0052 (by 0073), 0059 (by 0072), 0064 (by 0069), 0075 (by 0076). Each was verified from the amending ADR's own "Amends:" line. - The roadmap header gains a "Re-ratified: 2026-10-19" line, as every earlier re-ratification did. The §1 banner's stale "frontier is P10" line is annotated. - R3's row says its dependency was observed, matching R1.
vilosource
added a commit
that referenced
this pull request
Oct 19, 2026
… --tag (#355) * fix: the capture-fallback hint advertised --tags, which `add` rejects — it now says --tag The injected capture-fallback line (ADR-0065 §1) is what an agent pastes when the kb_* tools are gone. It advertised `add <type> "…" [--tags a,b]`, and the CLI rejects that with "unknown flag --tags", the very trap args.ts names (four entries once landed untagged). So the fallback failed at the moment it was needed. Found by the #354 review. - src/engine.ts: [--tags a,b] -> [--tag a,b]. - test/capture-fallback.test.ts: a behavioural guard, not a source grep. It pulls every [--flag value] out of the rendered line and runs the real built CLI `add` with them against a temp brain, then asserts the entry landed with the tags. Observed RED before the fix ("unknown flag --tags"), green after. Suite 816/816. * test: the fallback-hint guard checks every --flag token, not only [--lower value] (review round 1 M1) The gate on #355 found that the guard extracted only bracketed lower-case flags. The same --tags bug written unbracketed, a capitalised --Tag, or a bare --bogus all stayed green. Every --flag token after `add` is now extracted. Each of those three mutants, plus the original [--tags a,b], was observed red; green after restore. * review: ADR-0052 gate record for the fallback-hint fix — MERGE, 2 rounds --------- Co-authored-by: Jason Viloria <jason.viloria@oneio.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
vfkb add … --tags a,bbecomes--tag a,b. The real flag is--tag;--tagserrors withunknown flag --tags.docs/adr/README.md: backfills ADR-0067 to ADR-0076, generated from each ADR's owntitle:. The index is now complete, 0001–0077.ef3500b68252):docs/task-priority.md: the "roadmap is stale" banner is resolved.Docs and brain only. Brain note: besides this PR's decision
ef3500b68252, it carries two entries written into this checkout by a concurrent session (a91f82e76700,fc07da198bfa, Stop-hook nudge findings, 2026-10-19 12:37Z). They are kept, not dropped: the brain is append-only, and leaving them uncommitted risks losing them.🤖 Generated with Claude Code