Address JOSS reviewer code feedback: __version__, lockfile, sample data#94
Open
Address JOSS reviewer code feedback: __version__, lockfile, sample data#94
Conversation
The docs install snippet (`import meatpy; print(meatpy.__version__)`) was broken because the attribute did not exist. Source it from importlib.metadata so it stays in lockstep with pyproject.toml. Refresh the lockfile to pick up the 0.4.0 version that was already on PyPI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds samples/data/sample.itch50 (590 bytes, 20 messages, fictional symbols MEAT and PYTH) so users can run the parser, processor, and LOB end-to-end without a Nasdaq subscription. Includes the generator script, a README, and samples/itch50/00_quickstart.py demonstrating message-count and top-of-book reconstruction against the sample. Addresses the JOSS reviewer's request for bundled sample data. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the non-paper items from the JOSS reviewer's comment:
The paper-side fixes (typos, ITCH/IEX DEEP support text) are in #92 against the paper branch.
Test plan
🤖 Generated with Claude Code