Backport #2110: feat(nitro): add /_workflow web ui during dev#2224
Backport #2110: feat(nitro): add /_workflow web ui during dev#2224github-actions[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Rihan Arfan <me@file.properties>
🦋 Changeset detectedLatest commit: 1c708c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TooTallNate
left a comment
There was a problem hiding this comment.
Approve — AI-resolved conflicts hold up, faithful backport
This is a backport of #2110 (Nitro dev-mode /_workflow dashboard route) to stable. The backport bot called out that conflicts were AI-resolved; I went through the diff carefully and the resolution is correct.
Byte-identical to original
- Changeset ✓ byte-identical
package.json✓ adds@workflow/web: workspace:*dependency identicallyaddDashboardHandlerfunction body ✓ byte-identical (thecreateRequirelookup, thepathToFileURLURL wrapping, the lazy server start with promise caching, the two routing API variants withfromWebHandlerwrapping for the old one)
Stable-shape adaptations
The diff against stable differs from main in exactly two places, both for sound reasons:
-
Import line: stable doesn't already have
fileURLToPathimported, so the backport adds a freshimport { pathToFileURL } from 'node:url';line. Main hasfileURLToPathalready, so its diff addedpathToFileURLto the existing import. Same effective import. -
Regex change skipped: The original PR removed
web|web-sharedfrom a regex pattern in main'sisWorkflowPkgcheck. That regex doesn't exist on stable (it's a main-only addition from another PR for SWC workflow package detection). So skipping it is correct — there's nothing to update.
After stripping these two adaptation differences, the additions are byte-identical between the original and backport.
Verified locally
pnpm install --frozen-lockfile✓pnpm turbo run build --filter @workflow/nitro✓pnpm turbo run typecheck --filter @workflow/nitro✓
Dependency sanity check
@workflow/web/serverexportsstartServer(port)on stable ✓ (verifiedorigin/stable:packages/web/server.js)@workflow/webis in the workspace and a workspace dep gets added correctly
CI
CI doesn't show the Tests workflow runs yet — only deployments + DCO + Socket Security pass (21 checks). The PR was opened ~16 minutes ago by the github-actions[bot]; Tests may need a manual approval or just hasn't triggered yet. Worth verifying CI runs before merge but no functional issues from the diff itself.
Bottom line
Faithful backport. The dev-only /_workflow redirect lets Nitro projects access the workflow web UI in development without a separate pnpm workflow web command. Useful quality-of-life feature now on the GA channel. Approving.
Automated backport of #2110 to
stable(backport job run).AI recommendation: This is a self-contained minor feature addition to
@workflow/nitrothat adds a dev-only/_workflowroute. Bothpackages/nitro(with itsaddVirtualHandlerandnitro.routinginfrastructure) andpackages/web(including the./serverexport it depends on) exist onstable, so the change should apply cleanly and provides useful dev-mode functionality on the GA channel.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.