Skip to content

chore: standardize structural conventions for tool-* packages - #23942

Open
felixarntz wants to merge 2 commits into
mainfrom
fa/konsistent-tool-conventions
Open

felixarntz wants to merge 2 commits into
mainfrom
fa/konsistent-tool-conventions

Conversation

@felixarntz

Copy link
Copy Markdown
Collaborator

Background

The recently added first-party tool packages share several conventions, but konsistent did not enforce them.

Summary

  • Add a package-level konsistent convention for the shared tool main-file declarations and experimental factory barrel export.
  • Declare input/output schemas before their inferred types in the bash and web-fetch tools. More logical sequence because the types are inferred from their schemas.
  • The source changes only reorder declarations and do not change consumer-visible behavior or types, so no changeset was added.

Checks

  • pnpm type-check:full succeeded.
  • pnpm konsistent checked 3,343 files with no violations.
  • @ai-sdk/tool-bash tests: 34 passed.
  • @ai-sdk/tool-web-fetch tests: 53 passed; one charset-decoding test failed because the output contained U+0092 instead of the expected curly apostrophe.

Checklist

  • All commits are signed (PRs with unsigned commits cannot be merged)
  • Tests have been added / updated (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • A patch changeset for relevant packages has been added (for bug fixes / features - run pnpm changeset in the project root)
  • I have reviewed this pull request (self-review)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant