Skip to content

Revert "Check the optional-record path test's cast at the cast" #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctate merged 1 commit into from
Oct 21, 2026
Merged

Revert "Check the optional-record path test's cast at the cast" #1605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 6 additions & 31 deletions tests/harness/dyncheck.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,10 @@ console.log("unreachable", c.host);
// `Partial<T>` makes every member an `X | undefined` union. A present
// object that fails X used to report only the union's own path
// ("expected object | undefined at $.order, got object"); the record
// arm's builder now reports where inside it the value fails. The cast
// is passed straight to a typed parameter, so it is checked at the
// cast: one that initializes a block-local binding continues as its
// parsed value instead (checked-cast fallback), as in Node.
const types = `interface Order {
// arm's builder now reports where inside it the value fails.
const r = await compileAndRun(
"optional-record-deep",
`interface Order {
owner: { id: string; plan: { tier: string } };
total: number;
}
Expand All @@ -324,15 +323,10 @@ const texts = [
'{"order":{"owner":{"id":"u1","plan":{"tier":"pro"}},"total":3},"tags":["a",2]}',
'{"order":5}',
];
`;
const r = await compileAndRun(
"optional-record-deep",
`${types}function show(e: Partial<Envelope>): void {
console.log("ok", e.order?.owner.id);
}
for (const text of texts) {
try {
show(JSON.parse(text) as Partial<Envelope>);
const e = JSON.parse(text) as Partial<Envelope>;
console.log("ok", e.order?.owner.id);
} catch (err) {
if (err instanceof TypeError) console.log(err.message);
}
Expand All @@ -349,25 +343,6 @@ for (const text of texts) {
"",
].join("\n"),
);
const fallback = await compileAndRun(
"optional-record-deep-fallback",
`${types}for (const text of texts) {
try {
const e = JSON.parse(text) as Partial<Envelope>;
console.log("ok", e.order?.owner.id);
} catch (err) {
if (err instanceof TypeError) console.log(err.message);
}
}
`,
"ts",
true,
);
expect(fallback.stdout).toBe(
["ok u1", "ok 7", "ok u1", "Cannot read properties of undefined (reading 'id')", ""].join(
"\n",
),
);
});

test("JSON null matches nothing", async () => {
Expand Down
Loading