Repository navigation
Pipe into constructor-function streams natively in checked-dynamic stream slots - #1546
Merged
Merged
Conversation
…ream slots With checked-dynamic stream slots, stream.dynNative answered only boxed runtime streams, so a pipe into a constructor-function stream took the JavaScript listener protocol, and src.unpipe(this) in its 'pipe' listener had no runtime pipe to remove (6564-constructor-function-stream-late-hooks). In programs that link the constructor-function stream unit, stream.dynNative now answers such a stream's runtime stream, as stream.unboxDyn does there. A stream that overrides write() or end() still pipes through its JavaScript members.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
… order 6471's file reads Only pipe and unpipe destinations now take the constructor-function stream probe (stream.dynNativePipe). Member calls on a checked-dynamic stream slot use the boxed-native probe again, so a constructor-function stream's own pause(), resume() and on() still run (5820-node-stream-dyn-constructor-overrides). 6471 started its second file read on the first stream's 'end', so that stream's 'close' could land after the second stream's data. The second read now starts on 'close'.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src.unpipe(this)from its'pipe'listener, use the runtime's own pipe.6564-constructor-function-stream-late-hooks.cjs, which differed from Node after Let NodeJS stream interface slots hold JavaScript stream objects #1524 and Give constructor functions native stream state over the stream classes #1533 merged.