Repository navigation
Remove the last element of a packed array inline on pop - #1282
Merged
Merged
Conversation
pop and a discarded pop (the length - 1 store) branch on the array's length and hole-free prefix bound. When the bound equals the length, the last element is a present dense value: the emitted code clears its slot and state, lowers the bound and the length, and moves the slot out (or releases it for a discarded pop). An empty array answers undefined without a call. Holes, present undefined and sparse storage keep the runtime call.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pop()and discardedpop()on a hole-free dense array clear the last slot and lower the length in emitted code. Holes, presentundefinedand sparse arrays keep the runtime call.