Repository navigation
Conversation
Buffer.concat lowered only a statically typed Buffer[]/Uint8Array[] list or an array literal. Any other list, such as JavaScript's `const chunks = []`, reached an SC2020 fence at run time. Such lists now go to the runtime, which checks them as Node does (an Array whose elements are Uint8Arrays, ERR_INVALID_ARG_TYPE with Node's messages otherwise) before concatenating; the length form is covered as well.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| } | ||
| scr_arr_push_ref(parts, scr_bytes_retain(shown->v.bytes)); | ||
| scr_dyn_release(item); | ||
| } |
Contributor
There was a problem hiding this comment.
In Buffer.concat(list, length)'s untyped two-argument path, element-type validation runs before length validation, so an invalid element throws ERR_INVALID_ARG_TYPE before Node would throw the length ERR_OUT_OF_RANGE, diverging from Node's error ordering.
With untyped Buffer.concat lists and typeof on builtin module exports supported, the fixture runs to completion and matches Node, so its expected deferred SC2020 refusal is removed.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer.concataccepts lists whose type is not a staticBuffer[](such as JavaScript's untyped arrays), checking them at run time with Node'sERR_INVALID_ARG_TYPEerrors instead of stopping at an SC2020 fence.