Skip to content

fix(automation): drop closed windows from the snapshot window list #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phall1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(automation): drop closed windows from the snapshot window list #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/runtime/automation_snapshot.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,24 +46,39 @@ pub fn RuntimeAutomationSnapshot(comptime Runtime: type) type {
.text_layout_line_budget = canvas_limits.max_canvas_text_layout_lines_per_view,
};
}
var window_count: usize = 0;
var view_count: usize = 0;
var widget_count: usize = 0;
var menu_item_count: usize = 0;
for (self.windows[0..count], 0..) |window, index| {
self.automation_windows[index] = .{
// CLOSED windows are skipped, not reported. A closed window
// keeps its runtime table slot (with `info.open = false`)
// until its label or id is re-created — `removeWindowAt` runs
// at re-creation, not at close — so `self.windows[0..count]`
// still carries every window the app has ever declared. Their
// views are gone from `self.views` the moment they close, so
// an unfiltered pass published a window line with no views
// under it: a ghost that made every automation assertion on
// window COUNT (a settings window that must close, a
// reconciled window set) pass against a window that is not on
// screen. The output index advances only for the windows that
// survive the filter.
for (self.windows[0..count]) |window| {
if (!window.info.open) continue;
self.automation_windows[window_count] = .{
.id = window.info.id,
.title = if (window.info.title.len > 0) window.info.title else title,
.bounds = window.info.frame,
.focused = window.info.focused,
};
window_count += 1;
if (view_count < self.automation_views.len) {
const views = self.listViews(window.info.id, self.automation_views[view_count..]);
view_count += views.len;
}
appendAutomationWidgets(self, window.info.id, &widget_count, &menu_item_count);
}
return .{
.windows = self.automation_windows[0..count],
.windows = self.automation_windows[0..window_count],
.views = self.automation_views[0..view_count],
.widgets = self.automation_widgets[0..widget_count],
.commands = self.options.commands,
Expand Down