Conversation
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
`widget-key` dispatched a `key_down` and nothing else, so every key-lifetime latch it armed stayed armed. Those latches exist because a physical chord's release carries different modifier flags than its press (Cmd is often already up by the time G comes back), so the classification is latched on the view at the down and retired at the up -- `consumeCanvasWidgetTabInputFocusEntry`, `consumeCanvasWidgetTerminalPasteKeyLifetime`, and any app-level shortcut latch built the same way. With no release ever arriving, the SECOND drive of the same chord found the latch still held from the first and was swallowed as the missing release: `widget-key canvas cmd+g` twice in a row did the work once. Fixed by synthesizing the release, not by adding an explicit release action. Real hardware has no press without a release, so a harness able to emit an unpaired one is a harness able to reach states no user can; and pairing keeps every existing automation script's wire format AND its meaning intact -- one `widget-key` line is still one keystroke. A new release verb would instead have made correctness opt-in and left every script written before it driving half a keystroke. This is the discipline `widget-drag` (down/drag/up) and `widget-pinch` (begin/change/end) already follow, down to sharing one timestamp across the events because press and release are one gesture. The release carries the chord's modifiers but never `text`: `key_up` is deliberately barren in both text paths (`canvasWidgetTextEditEventFromGpuInput` and the target-less commit fallback), so it cannot double-insert what the press already typed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
phall1
force-pushed
the
upstream/widget-key-release
branch
from
September 20, 2026 00:01
74670ce to
a1418ed
Compare
phall1
marked this pull request as ready for review
September 20, 2026 05:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
widget-key currently emits only key_down, so key-lifetime latches stay armed and a repeated chord does the work once.
This synthesizes the matching key_up (same key, modifiers, and timestamp; no text on release).