Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…safe By cancellation-safe I mean that it will not kill the stream or drop data.
cancel_hook() used to cancel the asyncio future, delivering a CancelledError that no cancel scope owns. Raise a new HookCancelled exception in the awaiter instead. A duplicate resolve_hook() on a live hook raises FutureAlreadyFinished.
Under anyio a cancel scope stays cancelled, so code that catches a cancel and keeps going would lose the span's closing push.
MultiWaiter now waits on anything with an async wait() method, using a watcher task per item in its own task group, so it must be entered as an async context manager. ToolRunner uses util.create_task_group() and schedule() returns an anyio.TaskHandle. BoundToolCall catches anyio's cancel class so that cancelling a tool through its handle still produces an error result.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a long message but the gh client ate it.
A souped up decouple is used to protect async generators.
After building it I discovered that trio (but not anyio) has something
analagous: as_safe_channel.
Some stuff works under trio. I've found stuff that fails though.
I'll need to think more about cancellation; running user callbacks in
anyio tasks basically requires the users to use anyio if they want to
do cancellation safe cleanup, which is not great. (It is possible
though annoying to do cancellation safe cleanup in pure asyncio.)