Repository navigation
e2e: keep fixture sites outside the retention window clock - #145
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Set the generated site retention value web/playwright.config.ts:33, web/e2e/fixtures.ts:129 |
The generated site configuration and site-creation request now set retention_days to 0 instead of 30. |
Priority:
Merge Risk: 
2d466
-
The change preserves fixture data indefinitely and resolves the reported E2E expiry without an identified repository defect.
Architecture risk: 
49232
-
The change affects 1 system.
Changed systems:
webArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — web (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in web/playwright.config.ts: The generated site rows now set
retention_daysto0rather than30.
-
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title clearly states that E2E fixture sites must remain outside the retention window. It accurately summarises the main change. Description check The description explains the retention-window failure, identifies both changed files, and records local verification results. It directly relates to the changeset. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
The golden fixture days are fixed (2026-09-28..30) but the e2e owner site was created through the API with 30-day retention. Weekly rhythm (weekday/hour breakdowns) is rejected outside the retention window, so once the fixture aged past 30 days the card showed its retention error and had no busiest cell. Create the site with retention_days 0 (forever), like the file-registry sites.
velixio
changed the title
Root cause: weekly rhythm (weekday/hour breakdowns) is validated against the site's raw retention window (internal/query/plan.go validateTrafficRange). The e2e fixture days are fixed (2026-09-28..30) but the owner site used by web/e2e/fixtures.ts was created via the API with retention_days 30. From 2026-10-28 the oldest allowed day became 2026-09-29, so the request for 09-28 returned the retention error, the card rendered its error state and no gridcell had data-busiest. It is a date-dependent failure, not caused by #143.
Fix: create the e2e owner site with retention_days 0 (forever) in web/e2e/fixtures.ts, and keep the file-registry fixture sites in web/playwright.config.ts at 0 too. No assertions changed.
Verified locally: dashboard-where-when spec passes, and the CI dashboard group (10 spec files) passes, 18 tests.