Skip to content

chore: remove pnpm release age exclude config - #10125

Merged
sissbruecker merged 1 commit into
mainfrom
chore/remove-pnpm-release-age-exclude
Sep 15, 2026
Merged

sissbruecker merged 1 commit into
mainfrom
chore/remove-pnpm-release-age-exclude

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Follow-up to #10118
Related to vaadin/flow#25620

  • Removed the .pnpmfile.cjs from all 52 integration test modules, which excluded @vaadin/* packages from pnpm's minimum release age check
  • Removed the step in scripts/mergeITs.js that copied that file into the merged IT module
  • Removed the !**/.pnpmfile.cjs entry from vaadin-spreadsheet-flow-parent/.gitignore, which only existed to un-ignore the file from the .pnpm* pattern

Flow now passes --config.minimum-release-age-exclude=@vaadin/* to the pnpm install it runs, so the project-level exclusion is redundant. Every pnpm install in this repository goes through Flow — the IT builds, jetty:run, and scripts/wtr.js — so nothing else relies on it. The files stay on 25.2, which builds against a Flow version without the exclusion.

vaadin/flow#25620 passes --config.minimum-release-age-exclude=@vaadin/*
to the pnpm install it runs, so the per-module .pnpmfile.cjs that set the
same exclusion is redundant on this branch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@sissbruecker
sissbruecker added this pull request to the merge queue Sep 15, 2026
Merged via the queue into main with commit 8f6b28b Sep 15, 2026
44 of 46 checks passed
@sissbruecker
sissbruecker deleted the chore/remove-pnpm-release-age-exclude branch September 15, 2026 10:58
sissbruecker added a commit that referenced this pull request Sep 15, 2026
…0127)

This PR cherry-picks changes from the original PR #10125 to branch 25.3.
---
#### Original PR description
> Follow-up to #10118
> Related to vaadin/flow#25620
> 
> - Removed the `.pnpmfile.cjs` from all 52 integration test modules,
which excluded `@vaadin/*` packages from pnpm's minimum release age
check
> - Removed the step in `scripts/mergeITs.js` that copied that file into
the merged IT module
> - Removed the `!**/.pnpmfile.cjs` entry from
`vaadin-spreadsheet-flow-parent/.gitignore`, which only existed to
un-ignore the file from the `.pnpm*` pattern
> 
> Flow now passes `--config.minimum-release-age-exclude=@vaadin/*` to
the pnpm install it runs, so the project-level exclusion is redundant.
Every pnpm install in this repository goes through Flow — the IT builds,
`jetty:run`, and `scripts/wtr.js` — so nothing else relies on it. The
files stay on 25.2, which builds against a Flow version without the
exclusion.
>

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
ZheSun88 pushed a commit that referenced this pull request Sep 18, 2026
Cherry-pick of:
- #10118
- #10125

---------

Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants