chore: remove the @NpmPackage 24h gate - #10119
Merged
Merged
Conversation
vaadin/flow#25620 excludes @vaadin packages from the minimum frontend package age, so bumping an @NpmPackage version no longer produces a failed snapshot for downstream projects and the 24h block is obsolete on this branch. The gate stays on 25.2, which does not have the exclusion. Merge only after the flow cherry-pick vaadin/flow#25702 has landed in 25.3.
|
sissbruecker
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
@NpmPackage24h gate workflow (.github/workflows/npm-package-gate.yml) from 25.3. Same change as #10118 onmain.Why
The gate blocked every PR that added an
@NpmPackageversion for 24 hours, becausevaadin.npm.minimumFrontendPackageAgeDaysdefaults to1and a freshly published@vaadinpackage would otherwise break the snapshot builds of downstream projects.vaadin/flow#25620 ("exclude
@vaadinpackages from the minimum frontend package age") removes that reason: the minimum age no longer applies to@vaadinpackages.The cherry-pick of that fix to flow 25.3 — vaadin/flow#25702 — is still open at the time of writing. Please merge this PR only after vaadin/flow#25702 has landed, otherwise 25.3 loses the gate while flow 25.3 still enforces the minimum age for
@vaadinpackages.Scope
The gate is intentionally kept on 25.2, which does not get the exclusion.
Risk
Low, CI-only. The webjar/
@NpmPackageupdate PRs (e.g.chore: Update NpmPackages Webjars versions (25.3)) stop being blocked and auto-approved after 24h — they now follow the normal review and merge flow. Nothing in the build or in any component changes. Reverting is a single-file revert.How to test
Open or push a PR against 25.3 that adds an
@NpmPackageversion and check that noCHANGES_REQUESTEDreview from the review bot appears and no "NpmPackage 24h gate" workflow run is started.