Conversation
Update the documentation of observability-kit to match changes that made statements faulty.
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-5958.fly.dev Changed pagesAdded content is highlighted in green; removed content is marked in red on each page.
Built from 9d9a981 |
heruan
left a comment
There was a problem hiding this comment.
The edits themselves are accurate: three collectors, tripled capacity, getRecentClientErrors(), the grouping keys, the client counter descriptions and the client property all match the kit.
Since this PR was opened, two kit changes made more of reference.adoc stale. They are outside the diff, so listing them here rather than inline:
- Lines 498, 522 and 572 still name the span
vaadin.ui.access. It was renamed tovaadin.executor.taskin vaadin/observability-kit#397. The scope is now "tasks submitted to the Vaadin service executor" (signal effects, signal result notifications, application tasks), not everyUI.access. - Line 540 lists the request types as
uidl,heartbeat,push,static,other. vaadin/observability-kit#399 addedbootstrapandstream.
Optional: the replay example in insights.adoc around line 168 shows the production format only. Since vaadin/observability-kit#400, development mode adds view state steps such as Set the 'Reason' Select to 'Defective' and Click the 'Process return' Button. A sentence on that difference would help, but it can also be a follow-up.
Update the documentation of
observability-kit to match
changes that made statements faulty.