feat: add reload() DSL simulating a browser refresh (F5) - #158
Draft
Artur- wants to merge 3 commits into
Draft
Conversation
Adds reload() and reload(Class) to BaseBrowserlessTest, AbstractBrowserlessExtension and BrowserlessUIContext, delegating to a new BrowserlessDSL.reload(UI). A reload detaches the current UI and creates a fresh one in the same Vaadin session, then re-renders the current location; session-scoped state (attributes, security context) survives. Crucially this makes @PreserveOnRefresh work. Flow keys its preserved- component cache on window.name, but the mock never set ExtendedClientDetails, so the window name was always null and the cache was never populated. MockVaadin.createUI now assigns every UI complete ExtendedClientDetails with a stable, non-null window name (carried across a reload via a new lastWindowName ThreadLocal, fresh unique name per new window) and a real screenWidth so retrieveExtendedClientDetails resolves synchronously. Preserved views now keep their instance and state across a reload; plain views are recreated. Tests cover preserve-reuse, plain-reset, session survival and multi-window isolation.
Member
Author
|
/format |
This comment has been minimized.
This comment has been minimized.
github-project-automation
Bot
moved this to 🔎Iteration reviews
in Vaadin Flow | Hilla | Kits ongoing work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds reload() and reload(Class) to BaseBrowserlessTest, AbstractBrowserlessExtension and BrowserlessUIContext, delegating to a new BrowserlessDSL.reload(UI). A reload detaches the current UI and creates a fresh one in the same Vaadin session, then re-renders the current location; session-scoped state (attributes, security context) survives.
Crucially this makes @PreserveOnRefresh work. Flow keys its preserved- component cache on window.name, but the mock never set ExtendedClientDetails, so the window name was always null and the cache was never populated. MockVaadin.createUI now assigns every UI complete ExtendedClientDetails with a stable, non-null window name (carried across a reload via a new lastWindowName ThreadLocal, fresh unique name per new window) and a real screenWidth so retrieveExtendedClientDetails resolves synchronously. Preserved views now keep their instance and state across a reload; plain views are recreated.
Tests cover preserve-reuse, plain-reset, session survival and multi-window isolation.