Skip to content

grep - regex syntax errors print Oniguruma's wording instead of GNU's messages #185

Open

Description

@sylvestre

Known: #151 (open PR) — #151; #71 (merged PR) — #71

When a basic or extended pattern has a syntax error, both tools print nothing on stdout and
exit 2, but the message differs. GNU grep uses a small fixed set of messages
(Unmatched [, [^, [:, [., or [=, Unmatched ( or \(, Trailing backslash, ...).
uu_grep prints invalid pattern "<pattern>": <Oniguruma message>. Exit codes and match
results are fine; only stderr differs, which breaks scripts and test suites that compare it.

Reproduction

Rust (incorrect)

$ printf 'a\n' | ./target/release/grep '[a'
grep: invalid pattern "[a": premature end of char-class
# Exit code: 2

$ printf 'a\n' | ./target/release/grep '\(a'
grep: invalid pattern "\(a": end pattern with unmatched parenthesis
# Exit code: 2

$ printf 'a\n' | ./target/release/grep 'a\'
grep: invalid pattern "a\": end pattern at escape
# Exit code: 2

GNU (correct)

$ printf 'a\n' | LC_ALL=C /usr/bin/grep '[a'
grep: Unmatched [, [^, [:, [., or [=
# Exit code: 2

$ printf 'a\n' | LC_ALL=C /usr/bin/grep '\(a'
grep: Unmatched ( or \(
# Exit code: 2

$ printf 'a\n' | LC_ALL=C /usr/bin/grep 'a\'
grep: Trailing backslash
# Exit code: 2

Observed mapping (Oniguruma code -> GNU 3.12 message, LC_ALL=C):

Oniguruma error example GNU message
ONIGERR_PREMATURE_END_OF_CHAR_CLASS [a, [[:alpha:] Unmatched [, [^, [:, [., or [= (a lone trailing [ as in a[ gives Invalid regular expression)
ONIGERR_END_PATTERN_WITH_UNMATCHED_PARENTHESIS \(a, -E '(a' Unmatched ( or \(
ONIGERR_UNMATCHED_CLOSE_PARENTHESIS a\) Unmatched ) or \)
ONIGERR_END_PATTERN_AT_ESCAPE a\, -E 'a\' Trailing backslash
ONIGERR_INVALID_REPEAT_RANGE_PATTERN a\{1 / a\{x\} Unmatched \{ / Invalid content of \{\}
ONIGERR_INVALID_BACKREF \(a\)\2, -E '(a)\2' Invalid back reference

Root cause

src/matcher.rs:333, the fallback arm in compile_with inside CompiledPattern::compile:

let message = match err.code {
    ONIGERR_EMPTY_RANGE_IN_CHAR_CLASS => "Invalid range end".to_string(),
    _ => format!("invalid pattern \"{pattern}\": {}", err.message),
};

Only the reversed-range code is translated (added in #71); everything else falls through to
Oniguruma's text.

Test

#[test]
fn regex_syntax_errors_use_gnu_messages() {
    let cases: [(&[&str], &str); 5] = [
        (&["[x"], "Unmatched [, [^, [:, [., or [="),
        (&["\\(x"], "Unmatched ( or \\("),
        (&["-E", "(x"], "Unmatched ( or \\("),
        (&["x\\)"], "Unmatched ) or \\)"),
        (&["x\\"], "Trailing backslash"),
    ];
    for (args, message) in cases {
        let (_s, mut c) = ucmd();
        c.args(args)
            .pipe_in("x\n")
            .fails_with_code(2)
            .no_stdout()
            .stderr_is(format!("grep: {message}\n"));
    }
}

Reported by Anthropic's OSS Scanner (ANT-2026-PS745G19).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    gnu-compatBehaviour differs from GNUgood first issueGood for newcomersoss-scannerFound by Anthropic's OSS Scanner

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions