Repository navigation
diff: translate -F/-p groups to non-capturing groups - #376
Merged
Merged
Conversation
Only is_match() is called and back references are rejected, so nothing reads the captures, yet the regex engine kept slots for every group. A pattern with many repeated groups used over ten times the memory it needs.
Collaborator
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #350.
\(was translated to a capturing(, but we only callis_match()and back references are rejected, so the captures are never read. Emit(?:instead.With the pattern from the issue, peak RSS goes from ~177 MB to ~7 MB here (GNU diff: ~17 MB).
Added a unit test that the compiled regex has no capture groups.