Repository navigation
diff: color --color=auto output when TERM is unset - #372
Merged
Merged
Conversation
Only TERM=dumb disables colors in auto mode now, like GNU diff. An unset TERM (env -i, service managers, minimal containers) no longer turns colors off on a terminal. Fixes uutils#352
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Collaborator
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352
With
--color=auto, GNU diff colors the output on a terminal unlessTERM=dumb.output_palettealso requiredTERMto be set, so on a terminal with noTERM(env -i, some service managers, minimal containers) there were no colors. Auto mode now only turns colors off forTERM=dumb; an unsetTERMkeeps them.Tests:
tests/by-util/test_diff.rs: thecolortest now also runs--color=auto ---presume-output-ttywithTERMremoved and expects the colored output. It fails on main and passes with this change. The existingTERM=dumbcase still expects no colors.cargo test --test tests,cargo fmt --checkandcargo clippy -- -D warningsare clean. (Locally theed_diffpermutation unit tests can't run becauseedisn't installed here; everything else passes.)I used an AI assistant to write this change. I reviewed and tested it myself.