Skip to content

uucore::pipes::drain_pipe: catch 2nd+ splice's error - #13859

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:splice-drain-err
Aug 11, 2026
Merged

uucore::pipes::drain_pipe: catch 2nd+ splice's error#13859
sylvestre merged 1 commit into
uutils:mainfrom
oech3:splice-drain-err

Conversation

@oech3

@oech3 oech3 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Move #13847 to drain_pipe. Then the robustness of catching error is ported to tee command too.

@oech3
oech3 force-pushed the splice-drain-err branch from dd913a6 to 855f2cc Compare August 11, 2026 00:47
@oech3
oech3 marked this pull request as ready for review August 11, 2026 00:48
@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.93 MB (+316 KB, +0.21%)

Significant per-binary changes:
  install     1.24 MB ->    1.32 MB  (+80 KB, +6.29%)
  mkdir       1.09 MB ->    1.17 MB  (+80 KB, +7.14%)
  mkfifo      1.09 MB ->    1.16 MB  (+76 KB, +6.83%)
  mknod       1.09 MB ->    1.17 MB  (+76 KB, +6.79%)

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cat/splice is no longer failing!
Congrats! The gnu test tests/cut/mb-non-utf8 is no longer failing!
Congrats! The gnu test tests/mv/dir2dir is no longer failing!
Congrats! The gnu test tests/mv/mv-exchange is no longer failing!
Congrats! The gnu test tests/nl/multibyte is no longer failing!
Congrats! The gnu test tests/od/od-j is no longer failing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@oech3
oech3 force-pushed the splice-drain-err branch from 855f2cc to e4619a6 Compare August 11, 2026 07:00
@sylvestre
sylvestre merged commit 8768e40 into uutils:main Aug 11, 2026
164 checks passed
@oech3
oech3 deleted the splice-drain-err branch August 11, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants