chore: replace eslint with oxlint/oxfmt and add CI workflow - #23
Closed
tknkaa wants to merge 6 commits into
Closed
Conversation
Swap eslint/eslint-config-next for oxlint and oxfmt, and add a GitHub Actions workflow that runs lint, format:check, and typecheck on push/PR.
tknkaa
marked this pull request as ready for review
August 14, 2026 10:51
|
ciではtscよりもビルドをチェックすべきなのでは？(と思ったけどデプロイとプレビュー入れたらそのときにビルドすることになるからgithub actionでは不要か) (oxlint導入に関しては個人的には別にeslint+nextjs公式のプラグインのままでも無難で良いのではという気持ちはあります) |
next build already surfaces tsc errors; CI doesn't build separately (deploy pipeline does), so keeping a redundant typecheck job here just slows CI down for no extra safety.
Switch back from oxlint to eslint with the official eslint-config-next preset per review feedback, since it catches Next.js/React rules (e.g. react-hooks/set-state-in-effect) that weren't covered under oxlint's default config. oxfmt stays for formatting.
Contributor
Author
|
#25 に全変更（setup + format + fix）を統合したのでこちらはクローズします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap eslint/eslint-config-next for oxlint and oxfmt, and add a
GitHub Actions workflow that runs lint, format:check, and typecheck
on push/PR.
Stack created with GitHub Stacks CLI • Give Feedback 💬