Skip to content

Share location type strings in memory - #2947

Merged
DavyLandman merged 1 commit into
mainfrom
fix/memo-documentation-strings
Oct 22, 2026
Merged

DavyLandman merged 1 commit into
mainfrom
fix/memo-documentation-strings

Conversation

@toinehartman

@toinehartman toinehartman commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Memoize location documentation strings to make sure descriptions for equal types in a single summary are shared in memory.

Motivated by usethesource/rascal-language-servers#1202, @DavyLandman and I did an inspection of memory use in Rascal LSP. There are many duplicate strings in summaries.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45%. Comparing base (79680e7) to head (5be4bf4).

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2947   +/-   ##
=======================================
  Coverage       45%     45%           
- Complexity    6809    6813    +4     
=======================================
  Files          844     844           
  Lines        68823   68823           
  Branches     10038   10038           
=======================================
+ Hits         31414   31429   +15     
+ Misses       35010   34998   -12     
+ Partials      2399    2396    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavyLandman
DavyLandman merged commit 7860c84 into main Oct 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants