Skip to content

Fix summary memory leaks - #1246

Merged
DavyLandman merged 7 commits into
mainfrom
fix/summary-memory-leak
Oct 23, 2026
Merged

DavyLandman merged 7 commits into
mainfrom
fix/summary-memory-leak

Conversation

@toinehartman

@toinehartman toinehartman commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Fix memory leaks around file facts.

  1. When closing a file, remove the summary, even if there are remaining diagnostics.
  2. When closing a project, delete file facts for all files in that project.
  3. When deleting a file, remove the file facts.

Attempt to mitigate #1202.

@toinehartman toinehartman self-assigned this Oct 22, 2026
@toinehartman toinehartman added the bug Something isn't working label Oct 22, 2026

@DavyLandman DavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few questions.

Comment thread rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/rascal/model/FileFacts.java Outdated

@DavyLandman DavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better, some small concerns

Comment thread rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/rascal/model/FileFacts.java Outdated
@sonarqubecloud

Copy link
Copy Markdown

@DavyLandman
DavyLandman merged commit 6703d7c into main Oct 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants