Skip to content

fix: type-check engagement event detection #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KMKoushik merged 2 commits into from
Jul 13, 2026
Merged

fix: type-check engagement event detection #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4baf119
fix: type-check engagement event detection
KMKoushik Jul 13, 2026
255a718
ci: add web type check
KMKoushik Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test-web.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ jobs:
- name: Generate Prisma client
run: pnpm --filter=web db:generate

- name: Type check
run: pnpm --filter=web typecheck

- name: Prepare test database schema
run: pnpm --filter=web test:integration:prepare

Expand Down
1 change: 1 addition & 0 deletions apps/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"test:integration": "RUN_INTEGRATION=true vitest run -c vitest.integration.config.ts",
"test:integration:full": "pnpm test:integration:prepare:local && pnpm test:integration",
"test:coverage": "vitest run -c vitest.default.config.ts --coverage",
"typecheck": "tsc --noEmit --pretty false",
"db:post-install": "prisma generate",
"db:generate": "prisma generate",
"db:push": "prisma db push --skip-generate",
Expand Down
5 changes: 2 additions & 3 deletions apps/web/src/server/service/ses-hook-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,8 @@ export async function parseSesHook(data: SesEvent) {
return true;
}

const isEngagementEvent = [EmailStatus.OPENED, EmailStatus.CLICKED].includes(
mailStatus,
);
const isEngagementEvent =
mailStatus === EmailStatus.OPENED || mailStatus === EmailStatus.CLICKED;
const existingMailEvent =
email.campaignId || isEngagementEvent
? await db.emailEvent.findFirst({
Expand Down
Loading