Skip to content

Fix sirens crash #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CanerKaraca23 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix sirens crash #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ebeff4
Fix sirens crash by initializing vehicleData instead of skipping frames
CanerKaraca23 Apr 4, 2026
1275df6
Fix sirens crash by initializing vehicleData instead of skipping frames
CanerKaraca23 Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/features/sirens.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,13 +611,19 @@ void Sirens::Init()
int matIdx = GetSirenIndex(pVeh, pMat);

if (matIdx != - 1) {
if (!vehicleData.contains(pVeh)) {
vehicleData[pVeh] = new VehicleSiren(pVeh);
}
Comment on lines +614 to +616
int curState = vehicleData[pVeh]->GetCurrentState();
auto& state = modelData[pVeh->m_nModelIndex]->States[curState];
if (state->Materials.contains(matIdx)) {
if (modelData[pVeh->m_nModelIndex]->isImVehFtSiren) {
return MatStateColor{state->Materials[matIdx]->Color, state->Materials[matIdx]->Color};
} else {
return MatStateColor{state->Materials[matIdx]->Color, DEFAULT_MAT_COL};

if (curState >= 0 && curState < modelData[pVeh->m_nModelIndex]->States.size()) {
auto& state = modelData[pVeh->m_nModelIndex]->States[curState];
if (state->Materials.contains(matIdx)) {
if (modelData[pVeh->m_nModelIndex]->isImVehFtSiren) {
return MatStateColor{state->Materials[matIdx]->Color, state->Materials[matIdx]->Color};
} else {
return MatStateColor{state->Materials[matIdx]->Color, DEFAULT_MAT_COL};
}
}
}
}
Expand Down
6 changes: 0 additions & 6 deletions src/utils/modelinfomgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,12 +240,6 @@ RpMaterial *ModelInfoMgr::SetEditableMaterialsCB(RpMaterial *material, void *dat
{
auto &data = m_VehData.Get(pCurVeh);

// Sirens crash fix TODO: remove this and fix it
if (iLightIndex == eMaterialType::SirenLight && data.nFrameCount <= 10)
{
return material;
}

bool lightOn = false;
data.m_MatAvail[iLightIndex] = true;

Expand Down
Loading