Skip to content

fix(memo): make pinned memos easier to identify - #6369

Merged
boojack merged 2 commits into
mainfrom
fix/pinned-memo-indicator
Sep 22, 2026
Merged

boojack merged 2 commits into
mainfrom
fix/pinned-memo-indicator

Conversation

@johnnyjoygh

@johnnyjoygh johnnyjoygh commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Replace the easily missed header bookmark with a triangle at the card’s top-right corner, using the existing theme warning color. The marker grows from 20px to 24px on pointer hover and shows a localized “Pinned” tooltip. It scrolls with the card, and unpinning stays in the existing menu.

Fixes #6358

Validation: frontend lint, all 1,655 tests, production build, and git diff --check passed. Browser verification of the implementation was blocked by local preview access restrictions.

@johnnyjoygh
johnnyjoygh requested a review from a team as a code owner September 22, 2026 15:56
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: bab68af0-6599-4252-b80f-cee52ab23692

📥 Commits

Reviewing files that changed from the base of the PR and between 61ea071 and 2ddf731.

📒 Files selected for processing (53)
  • web/src/components/MemoView/MemoView.tsx
  • web/src/components/MemoView/components/MemoHeader.tsx
  • web/src/components/MemoView/components/MemoPinnedMark.tsx
  • web/src/components/MemoView/hooks/index.ts
  • web/src/components/MemoView/hooks/useMemoActions.ts
  • web/src/components/MemoView/types.ts
  • web/src/locales/ar.json
  • web/src/locales/az.json
  • web/src/locales/bg.json
  • web/src/locales/ca.json
  • web/src/locales/cs.json
  • web/src/locales/da.json
  • web/src/locales/de.json
  • web/src/locales/el.json
  • web/src/locales/en-GB.json
  • web/src/locales/en.json
  • web/src/locales/es.json
  • web/src/locales/et.json
  • web/src/locales/fa.json
  • web/src/locales/fi.json
  • web/src/locales/fr.json
  • web/src/locales/gl.json
  • web/src/locales/he.json
  • web/src/locales/hi.json
  • web/src/locales/hr.json
  • web/src/locales/hu.json
  • web/src/locales/id.json
  • web/src/locales/it.json
  • web/src/locales/ja.json
  • web/src/locales/ka-GE.json
  • web/src/locales/ko.json
  • web/src/locales/lt.json
  • web/src/locales/lv.json
  • web/src/locales/mr.json
  • web/src/locales/nb.json
  • web/src/locales/nl.json
  • web/src/locales/pl.json
  • web/src/locales/pt-BR.json
  • web/src/locales/pt-PT.json
  • web/src/locales/ro.json
  • web/src/locales/ru.json
  • web/src/locales/sk.json
  • web/src/locales/sl.json
  • web/src/locales/sr.json
  • web/src/locales/sv.json
  • web/src/locales/th.json
  • web/src/locales/tr.json
  • web/src/locales/uk.json
  • web/src/locales/vi.json
  • web/src/locales/zh-Hans.json
  • web/src/locales/zh-Hant.json
  • web/tests/memo-header-navigation.test.tsx
  • web/tests/memo-pinned-mark.test.tsx
💤 Files with no reviewable changes (4)
  • web/src/components/MemoView/hooks/useMemoActions.ts
  • web/tests/memo-header-navigation.test.tsx
  • web/src/components/MemoView/hooks/index.ts
  • web/src/components/MemoView/types.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

MemoView now renders a localized, non-interactive pinned marker for pinned memos. The marker uses a tooltip and hover styling. MemoHeader no longer renders the pin control or supports showPinned. The obsolete useMemoActions hook was removed. The memo.pinned translation was added to supported locales. Tests cover the marker semantics and remove the obsolete hook mock.

Suggested reviewers: bluedbird

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 2ddf7

This change adds a localized pinned-memo marker while retaining unpinning through the existing menu and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the pinned memo indicator redesign, tooltip behavior, retained unpinning flow, validation, and browser verification limitation.
Title check ✅ Passed The title accurately and concisely summarizes the main change: making pinned memos easier to identify.
Linked Issues check ✅ Passed The changes satisfy issue #6358. MemoView renders MemoPinnedMark when showPinned and memoData.pinned are true. The marker is absolutely positioned in the relative memo card, uses a warning col…
Out of Scope Changes check ✅ Passed The changes stay within issue #6358. The component relocation, removal of the old header indicator and its direct unpin handler, CSS card grouping, localization entries, and focused tests directly sup…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4…

Warning

Some tools did not complete. Review the errors below.

🔧 Biome (2.5.11)
web/src/components/MemoView/MemoView.tsx

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

web/src/components/MemoView/components/MemoHeader.tsx

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

web/src/components/MemoView/components/MemoPinnedMark.tsx

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

  • 46 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@boojack
boojack merged commit c2b8399 into main Sep 22, 2026
3 checks passed
@boojack
boojack deleted the fix/pinned-memo-indicator branch September 22, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pinned Memos visually distinguishable

2 participants