Repository navigation
build: install the JDKs the build's toolchains use - #624
Merged
Merged
Conversation
The workflow still pre-installed JDK 11 and 17 from the old testJdk11/17 tasks; the tests now run on 17, 21 and 25 (r8Jar also uses 21). Also let Gradle provision the toolchains build logic needs: the dependency diff workflow builds the base branch, which on a build-JDK bump needs the previous build JDK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mateuszkwiecinski
marked this pull request as ready for review
November 21, 2026 14:24
mateuszkwiecinski
enabled auto-merge
November 21, 2026 14:24
Jar size:Jar size change: +0.0B (3.5MiB -> 3.5MiB) Diffuse output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
default.yamlpre-installed JDK 11, 17. That list dates from 7dae945 (testJdk11/17). After 4f2cf8a the tests run on 17, 21, 25 andr8Jaruses 21. Nothing uses 11, so the list now mirrors the build: 17, 21, 25. The build JDK is still installed last from.java-version. Renovate skips this multi-line list, and chore(renovate): leave non-build JDKs in workflows alone project-starter#917 makes the preset ignore any non-build JDK in workflows.org.gradle.toolchains.foojay-resolver-conventiontogradle/plugins/settings.gradle.dependencies.ymlbuilds the base branch, and on a build-JDK bump (e.g. 27 → 28) the base build logic needs the previous build JDK, which no workflow installs. Simulated locally (java-compilation = "26", no JDK 26)::diffuse:dependenciesfailed before (:plugins:compileKotlintoolchain not found) and passes with this change. The rootsettings.gradlealready has the resolver, but it doesn't apply to the included build.🤖 Generated with Claude Code