Skip to content

build: install the JDKs the build's toolchains use - #624

Merged
mateuszkwiecinski merged 1 commit into
masterfrom
build/java-setup-unify
Nov 21, 2026
Merged

mateuszkwiecinski merged 1 commit into
masterfrom
build/java-setup-unify

Conversation

@mateuszkwiecinski

Copy link
Copy Markdown
Member

Changes

  • default.yaml pre-installed JDK 11, 17. That list dates from 7dae945 (testJdk11/17). After 4f2cf8a the tests run on 17, 21, 25 and r8Jar uses 21. Nothing uses 11, so the list now mirrors the build: 17, 21, 25. The build JDK is still installed last from .java-version. Renovate skips this multi-line list, and chore(renovate): leave non-build JDKs in workflows alone project-starter#917 makes the preset ignore any non-build JDK in workflows.
  • Adds org.gradle.toolchains.foojay-resolver-convention to gradle/plugins/settings.gradle. dependencies.yml builds the base branch, and on a build-JDK bump (e.g. 27 → 28) the base build logic needs the previous build JDK, which no workflow installs. Simulated locally (java-compilation = "26", no JDK 26): :diffuse:dependencies failed before (:plugins:compileKotlin toolchain not found) and passes with this change. The root settings.gradle already has the resolver, but it doesn't apply to the included build.

🤖 Generated with Claude Code

The workflow still pre-installed JDK 11 and 17 from the old testJdk11/17
tasks; the tests now run on 17, 21 and 25 (r8Jar also uses 21). Also let
Gradle provision the toolchains build logic needs: the dependency diff
workflow builds the base branch, which on a build-JDK bump needs the
previous build JDK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 14:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@mateuszkwiecinski
mateuszkwiecinski marked this pull request as ready for review November 21, 2026 14:24
@github-actions

Copy link
Copy Markdown

Jar size:

Jar size change: +0.0B (3.5MiB -> 3.5MiB)

Diffuse output:

OLD: diffuse-source-file
NEW: diffuse-unspecified-r8.jar

       │        compressed        │       uncompressed       
       ├─────────┬─────────┬──────┼─────────┬─────────┬──────
 JAR   │ old     │ new     │ diff │ old     │ new     │ diff 
───────┼─────────┼─────────┼──────┼─────────┼─────────┼──────
 class │ 1.8 MiB │ 1.8 MiB │  0 B │ 3.2 MiB │ 3.2 MiB │  0 B 
 other │ 1.7 MiB │ 1.7 MiB │  0 B │ 5.1 MiB │ 5.1 MiB │  0 B 
───────┼─────────┼─────────┼──────┼─────────┼─────────┼──────
 total │ 3.5 MiB │ 3.5 MiB │  0 B │ 8.3 MiB │ 8.3 MiB │  0 B 

 CLASSES │ old  │ new  │ diff      
─────────┼──────┼──────┼───────────
 classes │ 1372 │ 1372 │ 0 (+0 -0) 
 methods │ 7846 │ 7846 │ 0 (+0 -0) 
  fields │ 3379 │ 3379 │ 0 (+0 -0)

@mateuszkwiecinski
mateuszkwiecinski merged commit 8e98e9f into master Nov 21, 2026
2 checks passed
@mateuszkwiecinski
mateuszkwiecinski deleted the build/java-setup-unify branch November 21, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants