Skip to content

build: let Renovate bump the build JDK - #621

Merged
mateuszkwiecinski merged 2 commits into
masterfrom
claude/renovate-build-jdk
Nov 21, 2026
Merged

mateuszkwiecinski merged 2 commits into
masterfrom
claude/renovate-build-jdk

Conversation

@mateuszkwiecinski

Copy link
Copy Markdown
Member

Summary

Make the build JDK manageable by Renovate, as in usefulness/project-starter#911. This works: see usefulness/project-starter#913.

  • Extend github>usefulness/project-starter//.github/renovate/build-jdk. It tracks .java-version and the catalog's java-compilation, follows every GA JDK release (not just LTS), bumps all pins in one PR and never automerges.
  • The SetupCompilationPlugin's hardcoded jvmToolchain(25) now reads java-compilation from the catalog. That value goes from 21 to 25, so the included gradle/plugins build uses the same toolchain as the modules already did.
  • Workflows that installed extra JDKs plus the build JDK in one setup-java step now use two steps: the extra JDKs first, then the build JDK from .java-version. The last step sets JAVA_HOME, so behaviour is unchanged.
  • No version values change in this PR. Renovate's follow-up PR will move the build JDK to 27.
  • Bytecode targets (commonConfig.javaVersion, jvmTarget, options.release, java-target) are untouched.

JDK 27 notes

Gradle 9.9.2 supports JDK 27, and Kotlin 2.4.x compiles with a JDK 27 toolchain as long as jvmTarget is at most 26. Temurin 27 has no macOS x64 build. project-starter's full CI passed on JDK 27.

🤖 Generated with Claude Code

Extend the shared usefulness build-JDK Renovate preset so the JDK that runs
and compiles the build follows the latest GA release in one grouped,
non-automerged PR. Bytecode targets are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 08:23
@github-actions

Copy link
Copy Markdown

Jar size:

Jar size change: +0.0B (3.5MiB -> 3.5MiB)

Diffuse output:

OLD: diffuse-source-file
NEW: diffuse-unspecified-r8.jar

       │        compressed        │       uncompressed       
       ├─────────┬─────────┬──────┼─────────┬─────────┬──────
 JAR   │ old     │ new     │ diff │ old     │ new     │ diff 
───────┼─────────┼─────────┼──────┼─────────┼─────────┼──────
 class │ 1.8 MiB │ 1.8 MiB │  0 B │ 3.2 MiB │ 3.2 MiB │  0 B 
 other │ 1.7 MiB │ 1.7 MiB │  0 B │ 5.1 MiB │ 5.1 MiB │  0 B 
───────┼─────────┼─────────┼──────┼─────────┼─────────┼──────
 total │ 3.4 MiB │ 3.4 MiB │  0 B │ 8.3 MiB │ 8.3 MiB │  0 B 

 CLASSES │ old  │ new  │ diff      
─────────┼──────┼──────┼───────────
 classes │ 1352 │ 1352 │ 0 (+0 -0) 
 methods │ 7786 │ 7786 │ 0 (+0 -0) 
  fields │ 3319 │ 3319 │ 0 (+0 -0)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The included Gradle plugins build lacks explicit bytecode targets, so it inherits the raised target and a future bump to JVM 27 would exceed Kotlin 2.4.x support; pin its Kotlin and Java targets to 21 independently.

1 open issue
What changed in this PR

This PR makes the build JDK manageable by Renovate and centralizes toolchain selection while leaving explicit module bytecode targets unchanged.

Changes:

  • Adds the shared Renovate preset for grouped build-JDK updates without automerge.
  • Reads the compilation toolchain from the version catalog and raises its value from 21 to 25.
  • Separates extra CI JDK installations from the build JDK selected by .java-version.
File Description
renovate.json Enables the shared build-JDK update preset.
gradle/​plugins/​src/​main/​kotlin/​SetupCompilationPlugin.kt Replaces the hardcoded toolchain with the catalog value.
gradle/​libs.versions.toml Changes java-compilation from 21 to 25.
.github/​workflows/​default.yaml Installs the build JDK from .java-version after the extra JDKs.

Review effort: Balanced

Comment thread gradle/libs.versions.toml Resolved
@mateuszkwiecinski
mateuszkwiecinski marked this pull request as ready for review November 21, 2026 08:29
Copilot AI balanced review requested due to automatic review settings November 21, 2026 08:31
The included gradle/plugins build derived its jvmTarget from the toolchain,
so bumping java-compilation (e.g. Renovate to 27) would also raise the
bytecode target beyond what Kotlin 2.4 supports. Pin Kotlin jvmTarget and
javac --release to 17 independently of the build JDK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the build-JDK and toolchain alignment changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@mateuszkwiecinski
mateuszkwiecinski merged commit f74ea19 into master Nov 21, 2026
2 checks passed
@mateuszkwiecinski
mateuszkwiecinski deleted the claude/renovate-build-jdk branch November 21, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants