Repository navigation
build: let Renovate bump the build JDK - #621
Merged
Merged
Conversation
Extend the shared usefulness build-JDK Renovate preset so the JDK that runs and compiles the build follows the latest GA release in one grouped, non-automerged PR. Bytecode targets are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jar size:Jar size change: +0.0B (3.5MiB -> 3.5MiB) Diffuse output: |
There was a problem hiding this comment.
🟡 Changes recommended
The included Gradle plugins build lacks explicit bytecode targets, so it inherits the raised target and a future bump to JVM 27 would exceed Kotlin 2.4.x support; pin its Kotlin and Java targets to 21 independently.
1 open issue
What changed in this PR
This PR makes the build JDK manageable by Renovate and centralizes toolchain selection while leaving explicit module bytecode targets unchanged.
Changes:
- Adds the shared Renovate preset for grouped build-JDK updates without automerge.
- Reads the compilation toolchain from the version catalog and raises its value from 21 to 25.
- Separates extra CI JDK installations from the build JDK selected by
.java-version.
| File | Description |
|---|---|
renovate.json |
Enables the shared build-JDK update preset. |
gradle/plugins/src/main/kotlin/SetupCompilationPlugin.kt |
Replaces the hardcoded toolchain with the catalog value. |
gradle/libs.versions.toml |
Changes java-compilation from 21 to 25. |
.github/workflows/default.yaml |
Installs the build JDK from .java-version after the extra JDKs. |
Review effort: Balanced
mateuszkwiecinski
marked this pull request as ready for review
November 21, 2026 08:29
The included gradle/plugins build derived its jvmTarget from the toolchain, so bumping java-compilation (e.g. Renovate to 27) would also raise the bytecode target beyond what Kotlin 2.4 supports. Pin Kotlin jvmTarget and javac --release to 17 independently of the build JDK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mateuszkwiecinski
force-pushed
the
claude/renovate-build-jdk
branch
from
November 21, 2026 08:32
8cf217e to
e79a54f
Compare
mateuszkwiecinski
enabled auto-merge
November 21, 2026 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Make the build JDK manageable by Renovate, as in usefulness/project-starter#911. This works: see usefulness/project-starter#913.
github>usefulness/project-starter//.github/renovate/build-jdk. It tracks.java-versionand the catalog'sjava-compilation, follows every GA JDK release (not just LTS), bumps all pins in one PR and never automerges.jvmToolchain(25)now readsjava-compilationfrom the catalog. That value goes from 21 to 25, so the includedgradle/pluginsbuild uses the same toolchain as the modules already did.setup-javastep now use two steps: the extra JDKs first, then the build JDK from.java-version. The last step setsJAVA_HOME, so behaviour is unchanged.commonConfig.javaVersion,jvmTarget,options.release,java-target) are untouched.JDK 27 notes
Gradle 9.9.2 supports JDK 27, and Kotlin 2.4.x compiles with a JDK 27 toolchain as long as
jvmTargetis at most 26. Temurin 27 has no macOS x64 build. project-starter's full CI passed on JDK 27.🤖 Generated with Claude Code