Skip to content

🧪 CI: upload coverage on pushes to master too - #2023

Merged
chrisjsewell merged 1 commit into
masterfrom
claude/codecov-master-uploads
Oct 3, 2026
Merged

chrisjsewell merged 1 commit into
masterfrom
claude/codecov-master-uploads

Conversation

@chrisjsewell

Copy link
Copy Markdown
Member

Every Codecov upload step is guarded by github.event.pull_request.head.repo.full_name == github.repository, a guard against fork pull requests (#1229, August 2024) that has no value on a push event. So no push to master has uploaded a report since then; measured on the CI run for cc0ffe0, all five "upload to Codecov" steps are skipped.

Codecov compares a pull request against the newest ancestor that has a report. That ancestor is now d68d10d, 35 commits back and from before the sphinx-test-reports split (#2009), which moved statements out of the reports flag, so codecov/project/reports reads as a coverage drop (−0.74%) on every pull request, including ones that never touch the package (#2020 is the current example). A looser threshold in codecov.yml would hide this one delta while the base kept drifting; the cause is the missing upload.

What changes

What to expect

The first push to master after this merges uploads a fresh report; pull requests opened or rebased after that compare against it. Pull requests whose base is older, #2020 included, keep their current reports status until they rebase or merge; it is not a finding about them.

Split out of #2020 at review's request; that branch reverts its copy of the change.


Generated by Claude Code

The Codecov upload steps required github.event.pull_request.head.repo to
equal the repository, a guard against fork pull requests (#1229) that has
no value on a push event, so every upload on master was skipped (measured
on the run for cc0ffe0: all five "upload to Codecov" steps skipped).
Codecov then compared every pull request against the newest ancestor with
a report, 35 commits back and from before the sphinx-test-reports split
(#2009), so the reports flag read -0.74% on pull requests that never
touched the package. The guard now applies to pull request events only,
a push to master uploads under its own secrets, and fail_ci_if_error is
limited to pull requests so that a Codecov outage cannot turn master red.
@github-actions github-actions Bot added the pkg: workspace The repository as a whole: workflows, CI, release, docker, tooling, the workspace root label Oct 3, 2026
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (d68d10d) to head (46eb8f5).
⚠️ Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2023      +/-   ##
==========================================
+ Coverage   91.69%   91.87%   +0.17%     
==========================================
  Files         129      129              
  Lines       18155    18084      -71     
==========================================
- Hits        16648    16614      -34     
+ Misses       1507     1470      -37     
Flag Coverage Δ
codelinks 93.74% <ø> (+0.32%) ⬆️
mounts 94.26% <ø> (+0.24%) ⬆️
pytests 91.48% <ø> (+0.07%) ⬆️
reports 88.01% <ø> (-0.74%) ⬇️
ub-test-reports 90.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrisjsewell
chrisjsewell merged commit 1bae81a into master Oct 3, 2026
41 of 42 checks passed
@chrisjsewell
chrisjsewell deleted the claude/codecov-master-uploads branch October 3, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: workspace The repository as a whole: workflows, CI, release, docker, tooling, the workspace root

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants