Skip to content

Show the copy button and answer time on touch screens - #390

Merged
abhishekgahlot2 merged 1 commit into
useagenthq:mainfrom
tianxingjian2406:fix/issue-335
Oct 27, 2026
Merged

abhishekgahlot2 merged 1 commit into
useagenthq:mainfrom
tianxingjian2406:fix/issue-335

Conversation

@tianxingjian2406

@tianxingjian2406 tianxingjian2406 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #335

What changed

  • The copy button and the answer time under a finished reply fade in on hover only. Phones have no hover, so there was no visible way to copy an earlier reply. The row now carries pointer-coarse:opacity-100 and always shows on touch screens.
  • With a mouse, the row still appears on hover and on keyboard focus.

Testing

  • bun run typecheck, bun test components app lib, and bun run lint run clean (the known ghostty-web WASM baseline failure aside).
  • Manual check from the issue: in touch emulation at 390px, the copy button and the time are visible under every finished reply. With a mouse, the row still appears on hover and on focus.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 16:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tianxingjian2406

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@abhishekgahlot2

Copy link
Copy Markdown
Contributor

Thanks for this. Before we can merge, please add a before/after screenshot or a short screen recording of the change working in the running app (the issue asks for one), plus a line on how you tested it.

@tianxingjian2406

tianxingjian2406 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Screenshots at 390px with touch emulation (pointer: coarse, DevTools device mode), on /lab/session:

Before — the copy button and answer time stay hidden:

before: touch emulation, action row hidden
before: full phone view

After — the copy button and answer time are visible:

after: touch emulation, copy button and answer time visible
after: full phone view

How I tested it: I ran the app, enabled touch emulation at 390px, scrolled to a settled reply, and read getComputedStyle(row).opacity (0 before, 1 after). With a mouse the row still appears on hover or keyboard focus through the existing group-hover/turn and focus-within classes. The full suite passes (only the known ghostty-web baseline failure).

@abhishekgahlot2
abhishekgahlot2 merged commit f724049 into useagenthq:main Oct 27, 2026
1 of 2 checks passed
@abhishekgahlot2

Copy link
Copy Markdown
Contributor

Merged, thanks @tianxingjian2406, good catch for phones.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the copy button and answer time on phones

3 participants