Repository navigation
Approve in one click when the card has only one choice - #389
tianxingjian2406 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks for this. Before we can merge, please add a before/after screenshot or a short screen recording of the change working in the running app (the issue asks for one), plus a line on how you tested it. |
|
Screenshots from the running app (a card with exactly one option, same shape as Before — the option starts unselected, so Approve stays disabled: After — the single option starts selected, so Approve works on the first click: How I tested it: I mounted the real |
|
Thanks for the screenshots. Closing this one: #381 just replaced the old radio approval card, so a single-choice card now approves in one click on main, and this change no longer applies. |


Fixes #327
What changed
Testing
approval-card.test.tsxmounts the real card on happy-dom. With one option, Approve is enabled at once and a click approves that option. With two options, Approve stays disabled until a choice. The single-option case fails without the fix and passes with it.bun run typecheck,bun test components app lib, andbun run lintrun clean (the known ghostty-web WASM baseline failure aside).Need help on this PR? Tag
@codesmith-botwith what you need.