Skip to content

fix(start): stop the container when a poststart hook fails #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul05ranjan wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

fix(start): stop the container when a poststart hook fails #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cmd/urunc/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,18 @@ func startUnikontainer(cmd *cli.Command) error {
return err
}

return unikontainer.ExecuteHooks("Poststart")
if err := unikontainer.ExecuteHooks("Poststart"); err != nil {
// The spec requires a failing poststart hook to stop the container and
// continue with the delete transition (runtime.md, lifecycle step 9).
// The monitor keeps the guest alive otherwise, and a plain delete
// refuses while the container's init process still runs.
if killErr := unikontainer.Kill(); killErr != nil {
return errors.Join(err, fmt.Errorf("failed to stop the container after a failing poststart hook: %w", killErr))
}
return err
}

return nil
}

// startMonitorInit starts the urunc monitor process, blocked since create from
Expand Down