Pin unslothai/llama.cpp#235 (keep unparsed Qwen3-Coder output as content) - #236
danielhanchen wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef7080a2ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "https://github.com/unslothai/llama.cpp/pull/152/commits/b2b5ed9ff86427a530b762a45d3fdbd453bcd4e8", | ||
| "https://github.com/unslothai/llama.cpp/pull/176/commits/09ce1a4d2939844e211f7b4d30a296f4c1aed9a8" | ||
| "https://github.com/unslothai/llama.cpp/pull/176/commits/09ce1a4d2939844e211f7b4d30a296f4c1aed9a8", | ||
| "https://github.com/unslothai/llama.cpp/pull/235/commits/1ba5b7b7bf50123e1b70a6f58a11228a9412e759" |
There was a problem hiding this comment.
Register the new pin in feature-checks
When this pr-set.json change is pushed or submitted in a PR, the Every pin is either checked or knowingly unchecked step in .github/workflows/unsloth-pr-set-lint.yml derives unslothai#235 from this URL and exits with status 1 because that key appears in neither features nor unchecked in scripts/unsloth/feature-checks.json. Add a feature check or a documented unchecked entry for this pin so the required lint workflow can pass.
Useful? React with 👍 / 👎.
Adds #235 to the mix, last in the list.
#235 fixes the Qwen3-Coder parser (Qwen3.5 / 3.6 / 3.8, Nemotron Nano 3, StepFun) silently dropping any output after a
<tool_call>that does not parse, such as a call to a tool that is not offered or a call cut off by EOS. The client got a reply that ended mid-sentence withfinish_reason: "stop"and no tool call. In Unsloth Studio that showed up as a reply cut in the middle of a code block with no Continue button. Details and before / after tables are in #235.Checks
pin_contract.pyreports all 14 pins intact.feature-checks.jsonunderunchecked: the change is a chat parser fix covered bytest-chat, and none of the arch / backend-op / mtmd probes applies.common/chat.cpp,common/parsers/qwen3-coder.cppandtests/test-chat.cpp. The only other pin touchingcommon/chat.cppis ggml-org#25731 (Inkling), and it composes with it.Unrelated, found while checking
On newer base tags the existing pin set no longer merges (tonight's base is b11226): on b11205, ggml-org#24423 conflicts in
src/llama-context.cppand #176 intests/test-mtmd-impl.cpp, before #235 is reached. The last three nightlies (09-25 to 09-27) failed at Resolve tag on exactly this:ggml-org/llama.cpp#24423 (3dac51dc8) does not merge cleanly onto b11222, so the last mix release is still b11160. This PR does not change that, and #235 only reaches a release once ggml-org#24423 is repinned.