fix: contain exceptions thrown by consumer onLoad callback - #22
Merged
Merged
Conversation
|
@brenopolanski is attempting to deploy a commit to the Unlayer Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lucasbesen
approved these changes
Aug 28, 2026
Member
|
@brenopolanski thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A throw from
onLoadwas reported as a wrapper failure even though the editor had already mounted.Reproduction:
Fix
Wrap the
onLoadcall intry/catchand log the callback exception withconsole.error, the same wayfail()already contains a throwingonError.Note
This only happens when the consumer's own
onLoadthrows. Well-behaved callers are unaffected. The guard is cheap and keepsonErrorreserved for real wrapper failures.