Add per-note delay to step notes - #65
Merged
Merged
Conversation
Lets an individual step note nudge its start time (seconds or Tone notation like '32n'), as a per-note alternative to Song's global swing prop. Example app demos it with a manual-delay toggle on the arpeggio pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delayfield toStepNoteType(seconds or Tone notation like'32n') so an individual note can nudge its own start time, as a per-note alternative toSong's globalswingprop.buildSequencerStepandTrack's sequencer callback (Tone.Time(note.delay).toSeconds()offset added to the note's trigger time).Tone.Time()to the test mocks so existing/new tests don't need the real Tone context.delayto the off-beat note of the arpeggio pattern, for comparing against/combining with the swing slider. Minor CSS/layout cleanup for the controls grid.Test plan
npm test(src/__tests__/Track.test.tsx) passes