Repository navigation
fix: update Go toolchain to 1.26.10 for GO-2026-6809 - #142
Merged
Merged
Conversation
govulncheck failed on main after advisory GO-2026-6809 (Distrust compromised intermediate certificates in crypto/x509) was published. The vulnerable stdlib code is reachable under the go1.26.9 toolchain pinned in go.mod; the fix ships in go1.26.10. Bumps the go directive from 1.26.9 to 1.26.10. CI picks the toolchain from go.mod via go-version-file, so no workflow change is needed. Verified locally: govulncheck at the same pinned commit CI uses reports no vulnerabilities, and go build/vet pass under go1.26.10. Follows the precedent of #131. This failure was pre-existing on main and unrelated to PR #138. Assisted-by: Qwen3.8-27B-FP8 Signed-off-by: Yvonne Devlin <ydevlin@redhat.com>
yvonnedevlinrh
force-pushed
the
fix/pr-138-build-and-test
branch
from
October 21, 2026 14:45
9321a5a to
2f93c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
govulncheckstarted failingBuild and Testonmainafter advisory GO-2026-6809 (Distrust compromised intermediate certificates in crypto/x509) was published to the vulnerabilitydatabase. The vulnerable stdlib code is reachable under the
go1.26.9toolchain pinned ingo.mod; the fix ships ingo1.26.10.Bumps the
godirective from1.26.9to1.26.10. CI resolves the toolchain fromgo.mod(go-version-file: go.mod), so no workflow change is needed.Failure
First observed failing on
main(run 39608867872).
It surfaced during a rebase of PR #138, but the failure is pre-existing on the base branch and unrelated to that PR's change.
Precedent: #131 (same pattern: reachable stdlib vulnerability, fixed by a toolchain bump).
Verification
govulncheckat the same pinned commit CI uses (golang.org/x/vuln/cmd/govulncheck@3e6f44f): No vulnerabilities found undergo1.26.10go build ./...andgo vet ./...pass undergo1.26.10Follow-up
After merge, rebase PR #138 so its
Build and Testcheck runs ongo1.26.10and goes green.