Image Preview improvements - #653
Conversation
|
Chafa does improve a lot over halfblocks! It's just a huge pain in the ass to add, so I wouldn't bother unless you want to have "fun" with linking. The latest version has "sliced protocols", which would be a real killer feature here, since chats scroll all the time. It allows for partial rendering, so if the image is partially out of view, you can still render the visible parts (lines). |
|
In my test I've seen mixed results with I have an eye on the sliced protocols but for that we need a new @benjajaja What is the current state of |
|
That is a good question. I think we should stick to from_fontsize() right now, but there was recently some patch to address that, IIRC - to make from_query_stdio() use the ioctl of from_fontsize(), which seems to work on windows despite the queries not working. I'll check it, cut a release, and report back here. |
|
To be clear, that patch change I mentioned is not in any release yet, so we should keep using from_fontsize() for the time being, for windows. |
|
Yeah, I updated this PR to not call |
Also remove the `font_size` config option and restructure `TunableValues` a bit. And document "iterm2" suppor
This reverts commit 6b1cecf.
6cdb1c8 to
e4d47a1
Compare
This PR has a lot of small changes. I can break it into multiple PRs if you want.
ratatui-imageto9.0(further updates need a modalkit release to bumpratatui)settings.image_preview.protocol.typeis no longer required on windows (Picker::from_termios() for windows ratatui/ratatui-image#32)generating a picker from the font size has been deprecated and I have removed the settingsettings.image_preview.protocol.filterexposes the sample filter used to scale image previewsTriangleoverNearestgreatly improves image visibility at a marginally higher runtimefixes #650