Skip to content

Use setup-uv defaults for Python and the venv - #201

Merged
glenn-jocher merged 3 commits into
mainfrom
setup-uv-defaults
Oct 6, 2026
Merged

glenn-jocher merged 3 commits into
mainfrom
setup-uv-defaults

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Replaces actions/setup-python with ultralytics/actions/setup-uv. By default, that action now activates a venv on the newest Python preinstalled on the runner, with no Python download. Packages install into that venv, so --system is dropped. Jobs that pin a Python version keep the pin on setup-uv, which uses the preinstalled copy when the runner has one.

CI first ran against the setup-uv-defaults branch of ultralytics/actions#915. #915 is now merged (da5463a, released as 0.4.0), so setup-uv is back on @main, which carries the new defaults.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

The tag workflow now uses setup-uv defaults to prepare Python and install release dependencies in its virtual environment.

📊 Key Changes

  • Removed the separate actions/setup-python step.
  • Kept ultralytics/actions/setup-uv@main, which uses the runner’s preinstalled Python by default.
  • Dropped --system from the uv pip install ultralytics-actions command.

🎯 Purpose & Impact

  • The tag workflow installs ultralytics-actions into the virtual environment created by setup-uv, rather than into the system Python environment.

@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Oct 6, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/assets 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/assets main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR; the CLA check will comment with signing instructions if needed.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

LGTM. The workflow consistently uses setup-uv’s environment for installing and running the release tool; no regression is apparent. The temporary branch reference remains an operational dependency until it is reverted as described.

@UltralyticsAssistant
UltralyticsAssistant dismissed their stale review October 6, 2026 17:19

Superseded by new review

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review 2

Made with ❤️ by Ultralytics Actions

Since review 1, the workflow still points to setup-uv@main rather than the temporary defaults branch. Review 1's no-regression conclusion missed that #915 remains open: the changed install command can fail before publishing the release. (github.com)

💬 Posted 1 inline comment
  • ⚠️ HIGH .github/workflows/tag.yml:66 While actions#915 is still open, the setup step above still uses ultralytics/actions/setup-uv@main, so this job does not receive the new activated-venv default. With --system removed, uv pip install has no active environment and can fail before release publishing. Point the setup-uv step at @setup-uv-defaults until #915 merges, then switch back to @main. (github.com)

Comment thread .github/workflows/tag.yml

- name: Install dependencies
run: uv pip install --system ultralytics-actions
run: uv pip install ultralytics-actions

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultralytics/actions#915 merged at 17:18 UTC (da5463a, released as 0.4.0), so setup-uv@main now carries the new defaults and this CI run exercises them. The validation commit pointing at @setup-uv-defaults was already reverted, and the PR description is updated to match.

Comment thread .github/workflows/tag.yml

- name: Install dependencies
run: uv pip install --system ultralytics-actions
run: uv pip install ultralytics-actions

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultralytics/actions#915 merged at 17:18 UTC (da5463a, released as 0.4.0), so setup-uv@main now carries the new defaults and this CI run exercises them. The validation commit pointing at @setup-uv-defaults was already reverted, and the PR description is updated to match.

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review 3

Made with ❤️ by Ultralytics Actions

Since review 2, the concern about setup-uv@main is resolved: the PR discussion confirms #915 has merged. This diff removes standalone Python setup and installs dependencies without --system; no regression is evident. LGTM. The workflow still depends on the upstream behavior of setup-uv@main.

@glenn-jocher
glenn-jocher merged commit b64813c into main Oct 6, 2026
6 checks passed
@glenn-jocher
glenn-jocher deleted the setup-uv-defaults branch October 6, 2026 17:38
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #201 has been merged—thank you, @glenn-jocher, for updating the tag workflow to use setup-uv defaults and install ultralytics-actions in its virtual environment.

“Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.” — Antoine de Saint-Exupéry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops GitHub Devops or MLops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants