Repository navigation
Use setup-uv defaults for Python and the venv - #201
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
LGTM. The workflow consistently uses setup-uv’s environment for installing and running the release tool; no regression is apparent. The temporary branch reference remains an operational dependency until it is reverted as described.
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Since review 1, the workflow still points to setup-uv@main rather than the temporary defaults branch. Review 1's no-regression conclusion missed that #915 remains open: the changed install command can fail before publishing the release. (github.com)
💬 Posted 1 inline comment
⚠️ HIGH.github/workflows/tag.yml:66While actions#915 is still open, the setup step above still usesultralytics/actions/setup-uv@main, so this job does not receive the new activated-venv default. With--systemremoved,uv pip installhas no active environment and can fail before release publishing. Point the setup-uv step at@setup-uv-defaultsuntil #915 merges, then switch back to@main. (github.com)
|
|
||
| - name: Install dependencies | ||
| run: uv pip install --system ultralytics-actions | ||
| run: uv pip install ultralytics-actions |
There was a problem hiding this comment.
ultralytics/actions#915 merged at 17:18 UTC (da5463a, released as 0.4.0), so setup-uv@main now carries the new defaults and this CI run exercises them. The validation commit pointing at @setup-uv-defaults was already reverted, and the PR description is updated to match.
|
|
||
| - name: Install dependencies | ||
| run: uv pip install --system ultralytics-actions | ||
| run: uv pip install ultralytics-actions |
There was a problem hiding this comment.
ultralytics/actions#915 merged at 17:18 UTC (da5463a, released as 0.4.0), so setup-uv@main now carries the new defaults and this CI run exercises them. The validation commit pointing at @setup-uv-defaults was already reverted, and the PR description is updated to match.
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 3
Made with ❤️ by Ultralytics Actions
Since review 2, the concern about setup-uv@main is resolved: the PR discussion confirms #915 has merged. This diff removes standalone Python setup and installs dependencies without --system; no regression is evident. LGTM. The workflow still depends on the upstream behavior of setup-uv@main.
|
🎉 PR #201 has been merged—thank you, @glenn-jocher, for updating the tag workflow to use
|
Replaces
actions/setup-pythonwithultralytics/actions/setup-uv. By default, that action now activates a venv on the newest Python preinstalled on the runner, with no Python download. Packages install into that venv, so--systemis dropped. Jobs that pin a Python version keep the pin onsetup-uv, which uses the preinstalled copy when the runner has one.CI first ran against the
setup-uv-defaultsbranch of ultralytics/actions#915. #915 is now merged (da5463a, released as 0.4.0), sosetup-uvis back on@main, which carries the new defaults.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
The tag workflow now uses
setup-uvdefaults to prepare Python and install release dependencies in its virtual environment.📊 Key Changes
actions/setup-pythonstep.ultralytics/actions/setup-uv@main, which uses the runner’s preinstalled Python by default.--systemfrom theuv pip install ultralytics-actionscommand.🎯 Purpose & Impact
ultralytics-actionsinto the virtual environment created bysetup-uv, rather than into the system Python environment.