Repository navigation
Accept normalized CLA signature comments - #83
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
1 similar comment
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed .github/workflows/cla.yml. The change correctly broadens only the CLA signature comment gate while leaving recheck exact, and the downstream action remains responsible for normalized signature validation. No concrete regression found. LGTM.
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
No additional changes are present in the supplied diff since review 1. The signature gate remains broadened while recheck stays exact, and no concrete regression or security issue is evident. LGTM.
|
🎉 PR #83 has been merged—thank you, @glenn-jocher!
This focused update improves the CLA workflow by allowing recognized signature text with surrounding Markdown or trailing whitespace to reach normalization and validation, while preserving exact |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow gate to pass comments containing the recognized CLA signature text, allowing the action to normalize and validate signatures with surrounding Markdown or trailing whitespace.
📊 Key Changes
contains()check in.github/workflows/cla.yml.recheckcommand matching exact.🎯 Purpose & Impact
recheckbehavior remains unchanged.