Skip to content

Fix double escaping in fenced code previews #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaywcjlove merged 1 commit into from
Nov 4, 2026
Merged

Fix double escaping in fenced code previews #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions core/src/__test__/htmlEncode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import rehypePrism from 'rehype-prism-plus';
import type { PluggableList } from 'unified';
import { htmlEncode, processHtml } from '../utils';

it.each([
'```html\n<div title="x&y" />\n```',
'<div>&lt; & "quoted"</div>',
'```js\nif (a < b && b > 0) {}\n```',
])('preserves preview text and escapes markup: %s', (value) => {
const configurations: PluggableList[] = [[], [[rehypePrism, { ignoreMissing: true }]]];
for (const plugins of configurations) {
const container = document.createElement('div');
container.innerHTML = processHtml(`<pre><code class="language-markdown">${htmlEncode(value)}</code></pre>`, plugins);
expect(container.querySelector('code')?.textContent).toBe(value);
expect(container.querySelector('code > div')).toBeNull();
}
});
6 changes: 0 additions & 6 deletions core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ export const processHtml = (html: string, plugins: PluggableList = [] as Pluggab

export function htmlEncode(sHtml: string) {
return sHtml
.replace(/```(tsx?|jsx?|html|xml)(.*)\s+([\s\S]*?)(\s.+)?```/g, (str: string) => {
return str.replace(
/[<&"]/g,
(c: string) => (({ '<': '&lt;', '>': '&gt;', '&': '&amp;', '"': '&quot;' }) as Record<string, string>)[c],
);
})
.replace(
/[<&"]/g,
(c: string) => (({ '<': '&lt;', '>': '&gt;', '&': '&amp;', '"': '&quot;' }) as Record<string, string>)[c],
Expand Down
Loading