Repository navigation
ci: run tests on every pull request - #728
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-consumers.ymlonly ran when a pull request touched packaging files (package.json, consumer fixtures, or this workflow). Source and unit-test changes never started a run, so checks were missing on pull requests such as fix: keep highlighted textarea backgrounds transparent #721, fix: remount embedded HTML previews after source changes #726, and fix(editor): disable toolbar and resize controls with disabled prop #727.npm run coverage, andnpm run test:consumerssteps on every pull request intomaster.master, so a pull request branch is not tested twice. Pushes tomasterstill run coverage in the CI workflow.Test plan
package.jsonis unchangednpm run coverageandnpm run test:consumers