Repository navigation
Test/html comment regression 652 - #725
Merged
jaywcjlove merged 2 commits intoNov 2, 2026
Merged
Conversation
|
@hiyouwhatsapp is attempting to deploy a commit to the kenny wong's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions Bot
added a commit
that referenced
this pull request
Nov 2, 2026
* test: guard Markdown preview against unfinished HTML comments * test: declare rehype-sanitize used by preview regression bba4796
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #652
I tried the HTML input from the issue again and couldn't get it to crash on current master
Added tests for that and a couple other unfinished comments, with and without rehype sanitize across all 3 builds
Didnt change the rendering code as it seems to work already, wanted to keep the regression covered
189 tests pass and the package consumer build passes too