test: lock host targeting to what ssh -G resolves - #26
Merged
Merged
Conversation
The mount path passes whole host objects to the builders, so every command now carries an explicit -l/-p. Nothing proved those matched plain `ssh <alias>`, which is the failure a user would never think to check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #22 the mount path passes whole host objects to the SSH builders, so every command carries an explicit
-l/-p. That looked like it might overrideMatchorHost *blocks, butSSHConfig.get_host_configresolves throughssh -G, so those flags are OpenSSH's own resolved values — and the commands still target the alias, not the resolved hostname, so ssh re-resolves at connect time.Nothing covered that. These specs pin it for all four builders, plus the
user@host -p 2222case where the flags are the only way the target reaches ssh at all.No production code changes. Verified the specs fail when
append_host_optionsstops emitting the flags.