Skip to content

Fix Docker dependency PR automation#143

Merged
fqjony merged 3 commits into
latestfrom
fix-release-workflow-gates
Jun 24, 2026
Merged

Fix Docker dependency PR automation#143
fqjony merged 3 commits into
latestfrom
fix-release-workflow-gates

Conversation

@fqjony

@fqjony fqjony commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep Docker dependency releases push-driven by leaving updater auto-merge disabled
  • use the existing GH_TOKEN service-account secret for generated Docker dependency PR branch writes and optional merge commands, so push-triggered Build/Release workflows are not suppressed by github.token
  • make generated Docker dependency PRs request the udx/worker team and apply docker/dependencies labels
  • include the checkout v7 update from PR Bump actions/checkout from 6 to 7 in /.github/workflows #141
  • use peter-evans/create-pull-request@v8, matching the org preference for major Action tags instead of raw SHA pins
  • remove the temporary caller-side control gate from worker; docker-ops gate hardening belongs in udx/reusable-workflows

Validation

  • ruby YAML parse for docker-ops and docker-dependency-updater workflows
  • git diff --check for both workflow files

Notes

This fixes the PR #140 failure mode without manually releasing. The reusable docker-ops gate fix is intentionally separate and should land in udx/reusable-workflows.

Copilot AI review requested due to automatic review settings June 24, 2026 13:56
@fqjony fqjony added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code docker Pull requests that update docker code labels Jun 24, 2026
@fqjony fqjony self-assigned this Jun 24, 2026
@fqjony fqjony requested a review from a team June 24, 2026 13:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s GitHub Actions automation around Docker releases and Docker dependency update PRs, aiming to prevent an unsafe manual release path while keeping dependency update PRs non–auto-merged and better triaged.

Changes:

  • Added a control-gate job to fail fast when manually dispatching the Build/Release workflow on the latest ref, preventing docker-ops from starting.
  • Updated the Docker dependency updater workflow to disable auto-merge, and to apply labels + request the worker team as reviewer on generated PRs.
  • Bumped actions/checkout from v6 to v7 in the touched workflows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/docker-ops.yml Adds a pre-job gate to block manual latest dispatches and updates checkout to v7.
.github/workflows/docker-dependency-updater.yml Disables auto-merge for generated dependency PRs, adds labels/team review requests, updates checkout to v7, and grants issues: write for labeling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fqjony fqjony changed the title Fix release workflow gates and dependency PR automation Fix Docker dependency PR automation Jun 24, 2026
Copilot AI review requested due to automatic review settings June 24, 2026 14:48
Comment thread .github/workflows/docker-dependency-updater.yml Dismissed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@fqjony fqjony enabled auto-merge June 24, 2026 14:56
@fqjony fqjony merged commit 4d80fb7 into latest Jun 24, 2026
6 checks passed
@fqjony fqjony deleted the fix-release-workflow-gates branch June 24, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docker Pull requests that update docker code github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants