Repository navigation
feat(web): add readable change submission history pages - #791
Draft
behinddwalls wants to merge 3 commits into
Draft
behinddwalls wants to merge 3 commits into
behinddwalls wants to merge 3 commits into
Conversation
## Summary ### Why? Users need to inspect separate SubmitQueue submissions for a logical review or pinned version, including demo git changes. ### What? Add change-submission library presentation, host-owned GitHub/Phabricator/git URI adapters and labels, bounded receipt-window scanning, version navigation, and readable change routes. Wire change links into queue/request pages without exposing fake-provider hints or adding Next.js to the library. ## Test Plan Passed nine API/library/host check targets and the production Next standalone build, including change adapter and reader tests. Passed repository formatting, lint, module tidy, and Gazelle checks.
Git change links returned 404 because the route parser received encoded refs instead of decoded path segments. Decode each Next.js route segment exactly once before validating the change reference, preserving encoded slashes as part of the ref and leaving the shared library unchanged. Passed web checks and browser coverage for logical/pinned Git history, reloads, and literal percent escapes.
## Summary ### Why? Change history failed once the receipt window contained more than 500 queue requests, even when the selected change had only one submission. ### What? Return bounded history pages with gateway continuations rather than a resource-exhausted error. Keep page-scoped models, notices, empty states, and navigation in the reusable library; the Next host signs queue/change/version-scoped cursors, preserves snapshot bounds, and resets older pages to a live window on refresh. Preserve exact-version lookup and reject looping gateway cursors. ## Test Plan Passed change-branch web checks, package-consumer checks, production Next standalone build, formatting, lint, module tidy, and Gazelle checks. Added loader/component/reader regression tests for partial history, empty chunks, continuation, and repeated cursors.
This was referenced Oct 6, 2026
behinddwalls
added this pull request to stack #794
October 6, 2026 21:02
behinddwalls
removed this pull request from stack #794
October 6, 2026 22:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Users need to inspect repeated submissions for a logical PR, revision, or Git ref, including pinned versions. History must remain usable when a busy queue exceeds the demo scan budget.
What?
Add reusable change-submission presentation and paginated models, host-owned GitHub/Phabricator/Git identity adapters, readable change links, version navigation, and receipt-window lookup. Decode encoded Git refs exactly once, retain fake-provider hints only in backend values, and return bounded continuation pages instead of failing after 500 queue requests. The library renders page-scoped notices, empty states, and navigation; the host signs queue/change/version-scoped cursors, preserves snapshot bounds, and resets older pages to a live window on Refresh. Reject looping gateway cursors rather than presenting duplicate or falsely complete history.
Test Plan
Repository-native validation passed:
make test(141 targets),make lint,make check-tidy, andmake check-gazelle. The web generation, lint, typecheck, unit/component, and package-consumer checks passed on the complete stack. Change-branch loader/component/reader regressions and the production Next build passed. The real-stack suite covers logical/pinned Git history, reloads, literal percent escapes, and matching submissions on both sides of a >500-request pagination boundary.Stack