Repository navigation
fix(stovepipe): tag storage metrics by queue - #784
Merged
Merged
Conversation
Summary: Intent: - Make queue-filtered storage activity and latency visible; storage metrics currently omit the queue tag. Changes: - Tag the metric scope in Storage.For before constructing all seven queue-bound MySQL stores. - Add regression coverage for interleaved queues, preserved parent tags, and success, error, and cancellation outcomes. Rollout: Consumers must update their SubmitQueue dependency and deploy to emit the new queue-tagged series. Metric names and database behavior are unchanged; historical untagged metrics are not backfilled.
mnoah1
marked this pull request as ready for review
October 6, 2026 15:43
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 6, 2026 15:43
mnoah1
enabled auto-merge
October 6, 2026 15:43
behinddwalls
approved these changes
Oct 6, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Rollout:
Consumers must update their SubmitQueue dependency and deploy to emit the new queue-tagged series. Metric names and database behavior are unchanged; historical untagged metrics are not backfilled.
Test Plan