Repository navigation
Package ProGuard rules in Android AAR - #219
Open
Mr-KnightCLI wants to merge 1 commit into
Open
Mr-KnightCLI wants to merge 1 commit into
Mr-KnightCLI wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #215 by shipping consumer ProGuard/R8 rules at the root of the Android AAR. The rules preserve the
LatLngandH3Exceptionclasses and constructors that the JNI layer looks up by name.Validation
gradle androidAar -x buildH3Androidpassed, and I verified the generated AAR containsproguard.txtat its root with both keep rules.gradle testcould not pass locally because CMake is not installed, so the native H3 library was not built. The native-backed tests consequently failed to load that library; this is an environment limitation, not a passing test run.